Skip to content

Conversation

@PetrHeinz
Copy link
Member

@PetrHeinz PetrHeinz commented Jan 12, 2024

Previously, logs containing circular dependencies would be omitted (due to raised exception in JSON serialization).

Now, they are omitted and replaced by "<omitted circular reference>" (same as in https://github.com/logtail/logtail-js)

See tests for examples.

@PetrHeinz PetrHeinz requested a review from curusarn January 12, 2024 11:17
Copy link
Contributor

@curusarn curusarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Petr!

@PetrHeinz PetrHeinz merged commit b291afa into master Jan 12, 2024
@PetrHeinz PetrHeinz deleted the ph/circular-dependencies branch January 12, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants