Conversation
togop
previously approved these changes
Apr 8, 2021
| parser.add_argument('--remote_dir', help='the remote directory you want to sync', required=True) | ||
| parser.add_argument('--target', help='specify which remote machine to connect to', required=True) | ||
| parser.add_argument('project', nargs='?', default=None) | ||
| parser.add_argument('--register', help='Register a new project to code_sync', required=False) |
There was a problem hiding this comment.
could add at parser.add_argument('--register': , action='store_true' and in this way, the check could be just if args.register
Owner
Author
There was a problem hiding this comment.
The reason I did it the way I have it is so that you call code_sync -- register <project name> and that starts registering the <project name> project. Do you think it is a better interface to instead to code_sync --register and then code_sync asks for the name of the project?
matteobe
suggested changes
Apr 8, 2021
matteobe
approved these changes
Apr 13, 2021
Owner
Author
|
Hi @togop- Would you like to respond to my replies to your comments, or should I go ahead and merge this as is? |
togop
approved these changes
Apr 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can now run:
code_sync --register <project># prompts for configuration and saves to config filecode_sync <project>code_sync --list# lists registered projectsYou can also still run
code_syncthe old way, specifying the local_dir, remote_dir, etc manually.