Skip to content
This repository was archived by the owner on Jan 22, 2021. It is now read-only.

Conversation

@MickvanhetNederend
Copy link
Contributor

Great package, thanks. Just added the cc and bcc options (#52)

@johanbrook
Copy link
Contributor

Cool, thanks @Gekkejager!

There's no need to manually edit the HTML docs file though – I'm using docco to generate the HTML from code comments. So please discard the diff in the HTML file, and add appropriate docs as code comments instead, and I'll update the docs myself (see https://github.com/Gekkejager/meteor-emails/blob/master/update-docs.sh).

@MickvanhetNederend
Copy link
Contributor Author

@johanbrook thanks for your quick reply!

That makes sense. Since the other properties (subject etc) aren't elaborated and cc and bcc are rather self-explanatory I reckon no comments are required?

And how about the README.md, is that something I should alter by hand?

First PR from my side, sorry for the noobish questions.

@johanbrook
Copy link
Contributor

@Gekkejager No worries at all :) I'll take care of the README and docs stuff. Thanks again.

johanbrook added a commit that referenced this pull request Mar 3, 2016
@johanbrook johanbrook merged commit ce9ae8e into lookback:master Mar 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants