This repository was archived by the owner on Jun 29, 2022. It is now read-only.
A11y: Make Delete Button on Match Multiple Accessible to SR #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a naive, trial balloon PR to add an aria label to match multiple component, so that the "x" button on an item will be properly labeled for screen reader users. (This button removes the item from the list.) I have a couple of big questions that come with this PR that I would like to answer and address: 1. I have not been able to build the library locally, so am not 100% sure that this update will even have the effect I expect. What is the right way to build this locally, as there seems to be a mismatch between gulp and our current version of NodeJS, but when I downgraded NodeJS, I ran into a lot of other issues (perhaps a mismatch with XCode?). 2. Assuming that this update does what I expect, it is not localized. As far as I can tell, localizability is not handled at all in this library. What is the best way to address localization within this library? In theory this is a very simple fix, but I am hoping that folks with localization and library-specific expertise can shed some light on areas that are still opaque for me. Resolves DX-5500
micahbales
requested review from
RichardCzechowski,
jamesapowers and
rlm1023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a naive, trial balloon PR to add an aria label to match multiple component, so that the "x" button on an item will be properly labeled for screen reader users. (This button removes the item from the list.)
I have a couple of big questions that come with this PR that I would like to answer and address:
I have not been able to build the library locally, so am not 100% sure that this update will even have the effect I expect. What is the right way to build this locally, as there seems to be a mismatch between gulp and our current version of NodeJS, but when I downgraded NodeJS, I ran into a lot of other issues (perhaps a mismatch with XCode?).
Assuming that this update does what I expect, it is not localized. As far as I can tell, localizability is not handled at all in this library. What is the best way to address localization within this library?
In theory this is a very simple fix, but I am hoping that folks with localization and library-specific expertise can shed some light on areas that are still opaque for me.
Resolves DX-5500