Skip to content

Conversation

@bjorkert
Copy link
Contributor

Adds support for displaying insulin treatments with event type "External Insulin", enabling LoopFollow to show externally injected insulin alongside manual boluses.

@bjorkert bjorkert requested a review from marionbarker June 16, 2025 11:37
Copy link
Collaborator

@dnzxy dnzxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as the change looks good and builds on existing logic.

Minor general side note: these strings should be an enum.

@bjorkert bjorkert closed this Jun 20, 2025
@marionbarker
Copy link
Collaborator

Reopen at @bjorkert request.

@marionbarker marionbarker reopened this Jun 28, 2025
@marionbarker
Copy link
Collaborator

Test

Begin with LoopFollow v2.8.0

  • Loop - add external bolus - view in LoopFollow
    • IOB reflects the external bolus
    • External bolus is plotted on graph as a manual bolus as expected (blue circle)
    • Add carbs to force an automatic bolus
    • Automatic bolus is plotted on graph as automatic (blue triangle)
  • Trio - add external bolus - view in LoopFollow
    • IOB reflects the external bolus
    • External bolus is not shown in LoopFollow (although manual bolus from pump is shown)

Rebuild using the code in this PR.

  • Trio - add external bolus - view in LoopFollow
    • IOB reflects the external bolus
    • External bolus is shown in LoopFollow, both the new bolus and the older one

Copy link
Collaborator

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve from code review and test.

@marionbarker marionbarker merged commit 3788372 into dev Jun 28, 2025
@marionbarker marionbarker deleted the trio-external-insulin branch June 29, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants