update docker setup script #223
Conversation
bajtos
left a comment
bajtos
left a comment
There was a problem hiding this comment.
I am not familiar with Cloudant and cannot really asses impact of these changes. I am fine to land them as long as they work for you.
Please get at least one more approval, preferably from somebody more familiar with Cloudant.
| ## create database | ||
| printf "\n${RED}>> Creating database in Cloudant${PLAIN}" | ||
| curl --request PUT --url http://$USER:$PASSWORD@$HOST:$PORT/$DATABASE > /dev/null 2>&1 | ||
| curl -i -X PUT http://$USER:$PASSWORD@$HOST:$PORT/$DATABASE > /dev/null 2>&1 |
There was a problem hiding this comment.
Can we remove 2>&1, so that when the request fails, the errors are printed by the setup.sh script?
I also believe that -i is not necessary, since you are discarding the output to /dev/null anyways.
Quoting from man curl:
-i, --include
Include the HTTP-header in the output. The HTTP-header includes things like server-name, date of the document, HTTP-version and more...See also -v, --verbose.
Proposed line:
| curl -i -X PUT http://$USER:$PASSWORD@$HOST:$PORT/$DATABASE > /dev/null 2>&1 | |
| curl -X PUT http://$USER:$PASSWORD@$HOST:$PORT/$DATABASE > /dev/null |
There was a problem hiding this comment.
npm run mocha
npm run test
fail with some errors on my laptop, but works in CI build?
There was a problem hiding this comment.
hmm some tests fail on laptop with master branch too.
Why docker-compose use the :latest tag, but test.js use :2.0.1 ?
| ## create database | ||
| printf "\n${RED}>> Creating database in Cloudant${PLAIN}" | ||
| curl --request PUT --url http://$USER:$PASSWORD@$HOST:$PORT/$DATABASE > /dev/null 2>&1 | ||
| curl -i -X PUT http://$USER:$PASSWORD@$HOST:$PORT/$DATABASE > /dev/null 2>&1 |
There was a problem hiding this comment.
npm run mocha
npm run test
fail with some errors on my laptop, but works in CI build?
| version: "3" | ||
| services: | ||
| cloudant: | ||
| image: ibmcom/cloudant-developer:latest |
There was a problem hiding this comment.
This image is retired, I would suggest we use ibmcom/couchdb3 instead, see https://hub.docker.com/r/ibmcom/couchdb3.
It failed before the changes. |
|
closing as we've decided to use couchdb to run the test. |
|
@agnes512 , can you delete this branch now? Since this PR is not going to merge? thx. |
Description
connect to loopbackio/loopback-next#3968
The current script failed to create new database:
Update the script so that we can run acceptance tests in
repository-testson cloudant.Checklist
guide