fix: honor fields in the filter

[jannyHou]

Description

• Fixes the failure for missing FK in the fields

  • The fields filter was ignored and that's why the test above fails. This PR adds it to the query.
  • fromDB method will remove the id field is original filter doesn't have it in fields

• Fixes catching the inclusion error

  • _findRecursive invokes the include handler function without catching the error. That's why the test above returns null instead of throwing the expected error.
  • The fix exposed two new failures. They should have failed, while passed because the error was not propagated. The failure reason is the test case specifies order in filter but doesn't define index for the sortable field(which is required for couchdb2/cloudant connector).
  • The corresponding fix for ^ will be in juggler, we either make property title indexable for Post model, or skip that test for couchdb/cloudant connector. I will submit another PR.

Related issues

• connect to <link_to_referenced_issue>

Checklist

• New tests added or existing tests modified to cover all changes The test cases are in juggler.
• Code conforms with the style
  guide

[dhmlau]

commit message to be .. honor fields in the filter instead of ` hornor fields in the filter?

[bajtos]

I am not familiar with this code base, but don't see any obvious problems.

FWIW, LGTM.

[b-admike]

Not too familiar as well, but the explanation and code changes LGTM 👍

[dhmlau]

The changes look reasonable to me.
There are another set of failures in CI. Is it what you mentioned that after the existing issues are fixed, some other issues are exposed?

[jannyHou]

@dhmlau

There are another set of failures in CI. Is it what you mentioned that after the existing issues are fixed, some other issues are exposed?

Exactly.