When new required fields with a default value are added autoupdate shouldn't fail

[faridnsh]

Steps to produce:

1 - Create a model and run autoupdate/automigrate
2 - Add a new required property with a default value to the model for example:

    "newProperty": {
      "type": "Number",
      "required": true,
      "default": 0
    }

3 - Run autoupdate again

What's expected: New column should be added with the default value.

What actually happens: Autoupdate fails here and throws this:

error: column "newProperty" contains null values

It happens because it tries to add column with NOT NULL constraint, but this is only possible, if we give a default value, but loopback-connector-postgresql ignores the given default value in the model configuration.

I would like to contribute this myself, but I'm not sure if I'm getting the test configuration to work. I'm getting error: password authentication failed for user "user" for the first test, but the credentials in the configuration are correct and also a lot of other tests are failing.

[Elindorath]

@raymondfeng @superkhau @bajtos : I would like to address this issue, but I'm unable to run the test right now. I saw on the Readme that I need to contact you for instructions so I do.

[raymondfeng]

@Elindorath You have two ways to configure your postgres connection.

1. Set up env vars (https://github.com/strongloop/loopback-connector-postgresql/blob/master/test/init.js#L10)

export CI=true
export TEST_POSTGRESQL_HOST=localhost
export TEST_POSTGRESQL_PORT=5432
export TEST_POSTGRESQL_USER=myUser
export TEST_POSTGRESQL_PASSWORD=myPassword

Or drop .loopbackrc file into your home dir:

{
    "test": {
        "postgresql": {
            "host": "localhost",
            "port": 5432,
            "database": "test",
            "username": "test",
            "password": "testpass"
        }
    }
}

Please also use https://github.com/strongloop/loopback-connector-postgresql/blob/master/test/tables.sql to populate your test db.

[Elindorath]

Thanks @raymondfeng. I'll try to give you an update this week-end.

[zihehuang]

@Elindorath Any update on this issue? It seems that the connector is trying to add the column and set the NOT NULL attribute at the same time.

The way I worked around it was to drop the "required": true field and add the column to the database first. I then manually set the value of the column in Postgres. However, this is no different from doing everything manually and defeats the purpose of using a connector.