fix: honor non-unique property constraint

[ewrayjohnson]

Fixes: Fix - fail to honor non-unique property constraint #389

Connector does not honor non-unique constraint definition for a property declaration in model json file on automigrate.
Example model json file snipet:

"properties": [ 
  "email": {
    "type": "String",
    "index": {
      "unique": false
    }
  }
]

OR

"indexes": [
  "email_ndx" {
    "keys": [ "email" ],
    "options": {
      "unique": false
    }
  }
]

error generated: "could not create unique index "[modelname] _email_idx"

[slnode]

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

[dhmlau]

@ewrayjohnson, thanks for the PR. Could you please take care of a few things first?

• your PR is out of date, please rebase.
• Fix the commit linter error:

**************************************************
**
**  Linting commit logs
**
**  2 problems found:
**    8acaa10 - Improved fixed for ignoring creation of non-unique : First line should be 50 characters or less (saw 58)
**    8b0cafc - Fix - fail to honor non-unique property constraint: line 3 longer than 72 characters.
**
**************************************************

• add some tests to verify your changes.

FYI - Here is the instruction on how to change the commit message: https://help.github.com/en/github/committing-changes-to-your-project/changing-a-commit-message.

Thanks.

[bajtos]

Thank you @ewrayjohnson for the pull request.

Please add tests to verify your fixes and prevent regressions in the future. See test/postgresql.autoupdate.test.js for inspiration. I am not sure if the approach used by the existing tests can verify what indexes are created, feel free to run a direct SQL query to obtain information about the indexes in the database, for example:

ds.execute(
  'SELECT * from information_schema.key_column_usage', 
  function(err, result) => {
    // ...
  }
);

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.

[dhmlau]

We just switch the contribution method from CLA to DCO, making your contribution easier in the future. Please sign the commits with DCO by amending your commit messages with -s flag and push the changes again. If you're using the command line, you can:

git commit --amend -s
git push --force-with-lease

Please refer to this docs page for details. Thanks!

For more questions, please join our Slack workspace - #loopback-contributors.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.