Fix Promise/Callback variants in datasource types #1807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
requested review from
b-admike,
dhmlau,
emonddr,
jannyHou and
zbarbuto
as code owners
2 tasks
agnes512
approved these changes
Dec 5, 2019
emonddr
approved these changes
Dec 5, 2019
Contributor
emonddr
left a comment
emonddr
left a comment
There was a problem hiding this comment.
Only commit message needs fixing.
bajtos
force-pushed
the
fix/datasource-typings
branch
from
6210905 to
b80d604
Compare
jannyHou
reviewed
Dec 5, 2019
Remove usage of `PromiseOrVoid`, it makes it difficult to consume the API via `await`. For each async method, define multiple variants to correctly describe what's returned when a callback arg was provided (`void`) and what's returned when called with no callback (`Promise<T>`). Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
bajtos
force-pushed
the
fix/datasource-typings
branch
from
b80d604 to
19048cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usage of
PromiseOrVoid, it makes it difficult to consume the API viaawait. For each async method, define multiple variants to correctly describe what's returned when a callback arg was provided (void) and what's returned when called with no callback (Promise<T>).See loopbackio/loopback-next#4235 for background information.
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machine