feat: improve dataSource.execute to support more flavors
#1857
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the following variants:
execute(collection, command, ...params, options)(MongoDB)execute(...params)(forward-compatibility & other databases)This is a follow-up for #1855, which added type descriptions for
executevariants that turned out to be rejected by the actual (runtime) implementation. See also loopbackio/loopback-next#3342The changes is pushing the responsibility for processing optional arguments (
(cmd),(cmd, args),(cmd, args, options)) to the connector. This should be fine because the baseSqlConnectoralready handles optional arguments (see lib/sql.js#L551-L563), and we weren't really supporting non-SQLexecutebefore.Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machine