Column names in lowercase using lb4 discover method - SQL connector

[sureshkodur]

Describe

Hi Team. I'm generating models from SQL db using lb4 discover method. But, the column names generating in lowercase. While in my SQL db, they are in camelCase. See, below code:

@property({
    type: Number,
    required: true,
    precision: 10,
    scale: 0,
    id: 1,
    mssql: 
         {"columnName":"ErrorID",
          "dataType":"int",
          "dataLength":null,
          "dataPrecision":10,
          "dataScale":0,"
          nullable":"NO"
         },
  })
  errorid: Number;

Current behavior

The column name is generated in lowercase as errorid instead of ErrorID.

Expected Behavior

• Would like to get the column name ErrorID as it is.

Acceptance Criteria

• column names should default to camelCase instead of lowercase
• add a prompt of 2 options when doing lb4 discover
  • column names to property names:
    • camelCase ( LB4 default, recommended)
    • keep it the same as the column names ( warning: might cause unexpected behavior. please read the ....file)
• enhance the documentation. List out options and their limitations.

Out of scope:

• an extension point allowing users to provide custom function to transform database column names to LB4 property names

[sureshkodur]

@bajtos , @emonddr , @raymondfeng, @ritch , Can anyone, any update on this. Help me

[dhmlau]

@agnes512, could you please take a look? Thanks.

[agnes512]

I reproduced the above issue by using lb4 discover --schema testdb with datasource config:

{
 "name": "db",
 "connector": "mysql",
  ...
 "database": "testdb"
}

I can access database with the generated models. I figured that this issue is more about developer-experience instead of a bug. And the lowerCamelCase name might be generated here, not sure about it.

As for the naming convention feature, it needs further discussion.
Will link this issue to other similar issues.

[agnes512]

@sureshkodur Hi! I was testing it out yesterday. And it does generate errorid instead of ErrorID. If it has errors because the naming convention, we would label it as a bug. But it works fine for me.
Are you getting any errors causing by the names?

[sureshkodur]

@agnes512 , In my MSSQL db, it has the column name as 'ErrorID', which is in Uppper CamelCase. But when I'm trying to generate schema using lb4 discover it is errorid instead of ErrorID. But I need it as ErrorID in model. Are you understand the issue?

[agnes512]

@agnes512 , In my MSSQL db, it has the column name as 'ErrorID', which is in Uppper CamelCase. But when I'm trying to generate schema using lb4 discover it is errorid instead of ErrorID. But I need it as ErrorID in model. Are you understand the issue?

Yes. After getting models from MySQL, do you still use MySQL as your database? In my case, I did, and the app works fine, by that I mean, my application can store/get data via MySQL even it is using errorid.

That's why I figured the naming convention does not cause functional errors. It's about how we convert column names to property names. This issue is more about dev experience. That's why I changed the label, which helps us to plan things out. 😄

If you're getting any functional errors (such as API doesn't work, controller generating error) because of the naming, please let me know, and how I can reproduce it.

[sureshkodur]

@agnes512 , Are you read that message properly.. Its not MySQL. Its MSSQL... Can you check it once with MSSQL? @rmg

[agnes512]

@sureshkodur Hi, I also tried it out on MSSQL. I got the same result: reproduced that issue, and the App still works. i.e I can use POST/GET APIs to interact with MSSQL. Here is my datasource config:

{
  "name": "db",
  "connector": "mssql",
  "host": "localhost",
  "port": 1433,
  "user": ...,
  "password": ... ,
  "database": "master"
}

Like I mentioned above, I believe this (ErrorID -> errorid) is because of the naming convention that we are using.
It is not a functional error of any specific connectors.

Sorry that we don't have naming convention options available for now. You can still change errorid to ErrorID manually as a workaround. I believe that the App would still work.

Thanks