Garden path tutorial - rename getting-started to todo, add tutorial to docs #1199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virkt25
changed the title
virkt25
added a commit
to loopbackio/loopback.io
that referenced
this pull request
Mar 27, 2018
related to #729 to land after loopbackio/loopback-next#1199
shimks
approved these changes
Mar 28, 2018
b-admike
approved these changes
Mar 28, 2018
bajtos
reviewed
Mar 29, 2018
CODEOWNERS
Outdated
| packages/context/* @bajtos @raymondfeng | ||
| packages/core/* @bajtos @raymondfeng | ||
| packages/example-getting-started/* @bajtos | ||
| packages/example-todo/* @bajtos |
Member
There was a problem hiding this comment.
Can we get at least one more additional CODEOWNER for this package?
Contributor
Author
There was a problem hiding this comment.
I'm familiar enough with the package. I'll add myself.
raymondfeng
approved these changes
Mar 29, 2018
BREAKING CHANGE: example-getting-started is now example-todo
virkt25
added a commit
to loopbackio/loopback.io
that referenced
this pull request
Mar 29, 2018
related to #729 to land after loopbackio/loopback-next#1199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connected to #729
related discussion can be found at loopbackio/loopback.io#601
First Commit
Second Commit
Tests will FAIL till this PR lands as cli is not able to clone
example-todoChecklist
npm testpasses on your machinepackages/cliwere updatedpackages/example-*were updated