chore: add a sandbox location to enable testing w/ source code #1252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virkt25
reviewed
Apr 12, 2018
Contributor
virkt25
left a comment
virkt25
left a comment
There was a problem hiding this comment.
Should we add sandbox/* to .gitignore to prevent someone from accidentally committing stuff in this folder?
raymondfeng
force-pushed
the
add-sandbox
branch
from
f3a9be2 to
3f3595a
Compare
Contributor
Author
Yes. I forgot to commit |
shimks
reviewed
Apr 12, 2018
| @@ -0,0 +1,4 @@ | |||
| **/* | |||
Contributor
There was a problem hiding this comment.
Can't we do this at the top level?
Contributor
Author
There was a problem hiding this comment.
I wanted to keep it isolated to the sandbox directory. But no strong objections to move it to top.
virkt25
approved these changes
Apr 12, 2018
shimks
approved these changes
Apr 12, 2018
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR formalizes the idea to allow packages to be tested against our source code from git. It adds a
sandboxfolder to contain modules/applications that need to be bootstrapped by lerna.Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated