refactor: clean usage of OAI's ExtensionValue

[bajtos]

Move the definition of ExtensionValue from openapi-v3-types (where it is no longer used) to openapi-spec-build.

Fix openapi type guards to use a more correct object type instead of ExtensionValue, since the guards are not dealing with any extensions.

Fixa json-to-schema converter to use any instead of ExtensionValue when converting a JSON Schema object to an indexable object.

This is a follow-up for #1265.

Checklist

• npm test passes on your machine
• (n/a) New tests added or existing tests modified to cover all changes
• Code conforms with the style guide
• (n/a) API Documentation in code was updated
• (n/a) Documentation in /docs/site was updated
• (n/a) Affected artifact templates in packages/cli were updated
• (n/a) Affected example projects in examples/* were updated

[jannyHou]

LGTM, just curious, any reason to export ExtensionValue from openapi-spec-builder instead of openapi-v3?
And one minor comment.

[jannyHou]

hmm, any reason changing ExtensionValue to any? I thought this PR aims at importing ExtensionValue from openapi-spec-builder.
Not a big deal though.

[bajtos]

JSON Definition is a JSON Schema object containing well-known keys and values:

export interface JsonDefinition extends Definition {
  allOf?: JsonDefinition[];
  oneOf?: JsonDefinition[];
  anyOf?: JsonDefinition[];
  items?: JsonDefinition | JsonDefinition[];
  additionalItems?: {
    anyOf: JsonDefinition[];
  };
  enum?: PrimitiveType[] | JsonDefinition[];
  additionalProperties?: JsonDefinition | boolean;
  definitions?: {[definition: string]: JsonDefinition};
  properties?: {[property: string]: JsonDefinition};
}

There are not OpenAPI spec extensions involved AFAICT, therefore we should not be using ExtensionValue type.

Based on the comment in the code, my understanding is that we need to cast from JsonDefinition to a string-key-to-any-value object/map to fix a compiler error in the default case below:

default:
  result[property] = json[property];
  break;

I found a more elegant way how solve this problem by casting property to keyof JsonDefinition, see 8de9b75.

[raymondfeng]

Can we use https://github.com/metadevpro/openapi3-ts/blob/master/src/model/SpecificationExtension.ts#L7-L10 instead?

[raymondfeng]

Extendable should be Extensible.

[bajtos]

We can use ISpecificationExtension instead of Extendable. However, openapi3-ts does not come with any alias type similar to our ExtensionValue, that's why I thought it's better to preserve both our types.

OTOH, this is not a big deal. I think the benefits of using ISpecificationExtension are worth it.

I have updated the code accordingly, see a9e4ab9.

[bajtos]

any reason to export ExtensionValue from openapi-spec-builder instead of openapi-v3?

@jannyHou since ExtensionValue is not used anywhere in openapi-v3, I feel it's better to leave it out and keep openapi-v3 package smaller. Ideally, this type alias for any should be defined in openapi3-ts.

Based on Raymond's feedback, I removed this type alias entirely.

---

@raymondfeng @jannyHou PTAL again.

I'll clean up the git commit history (squash all commits to a single one) after the patch gets approved.

[jannyHou]

any or any alias are both fine to me, as long as the usages are identical across all packages.
👍 LGTM!