refactor(repository-json-schema): rename JSONSchema to JsonSchema #1288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our current convention is to treat abbreviations longer than 2 characters as regular words and capitalize only the first character. We already use "Json" form across the codebase instead of "JSON". This commit applies the same convention to the JSON Schema type introduced by the recent commit e9e6b12.
Contributor
|
hmm ... I'm ok with the change but I personally prefer |
shimks
approved these changes
Apr 27, 2018
raymondfeng
approved these changes
Apr 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current convention is to treat abbreviations longer than 2
characters as regular words and capitalize only the first character.
We already use "Json" form across the codebase instead of "JSON".
This commit applies the same convention to the JSON Schema type
introduced by the recent commit e9e6b12 (see #1286).
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated