[PoC] feat(validator): add in a JSON Schema validator decorator #1294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondfeng
reviewed
Apr 27, 2018
| ); | ||
| } | ||
| // tslint:disable-next-line:no-any | ||
| descriptor.value = async function(...args: any[]) { |
Contributor
There was a problem hiding this comment.
Creating a method proxy via @validatable probably has its constraints - for example, it won't have access to the Context for some of the validators to be instantiated and executed. Only isolated validations can be performed by this fashion.
This was referenced Apr 30, 2018
1 task
Member
|
@shimks what's the status of this pull request, can we close it as done (but don't merge)? |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated