refactor(rest): mount CORS as a regular middleware #1338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
added
the
REST
virkt25
approved these changes
May 17, 2018
shimks
approved these changes
May 17, 2018
raymondfeng
approved these changes
May 17, 2018
jannyHou
approved these changes
May 17, 2018
Clean up the RestServer implementation by moving CORS out of _handleHttpRequest() and mounting it as a regular Express middleware instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the RestServer implementation by moving CORS out of
_handleHttpRequest()and mounting it as a regular Express middleware instead.This is a follow-up for #1326 as part of #1038.
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated