chore(repository): separate execute function from repository interface #1414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
suggested changes
Jun 12, 2018
Member
bajtos
left a comment
bajtos
left a comment
There was a problem hiding this comment.
Please annotate DefaultCrudRepository as implements ExecutableRepository.
Member
|
I think this pull request needs an approval from @raymondfeng before it can be landed. |
shimks
force-pushed
the
repository/move-execute-out
branch
from
eade1c9 to
14a312c
Compare
jannyHou
reviewed
Jun 12, 2018
| export interface Repository<T extends Model> { | ||
| export interface Repository<T extends Model> {} | ||
|
|
||
| export interface ExecutableRepository<T extends Model> extends Repository<T> { |
Contributor
There was a problem hiding this comment.
The git compare is weird, it should show the entire new interface instead of the declaration part only.
@shimks Do we still need the execute function in https://github.com/strongloop/loopback-next/blob/14a312c91639769111c829b07b37fa9e13b4bf4f/packages/repository/src/repositories/repository.ts#L333?
Contributor
Author
There was a problem hiding this comment.
According to @bajtos, DefaultCrudRepository should extend from an executable repository, so I guess we still do :p
raymondfeng
approved these changes
Jun 13, 2018
jannyHou
approved these changes
Jun 13, 2018
bajtos
approved these changes
Jun 14, 2018
shimks
force-pushed
the
repository/move-execute-out
branch
2 times, most recently
from
5009a5b to
0699a8f
Compare
shimks
force-pushed
the
repository/move-execute-out
branch
from
0699a8f to
9b6607c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1355
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated