Skip to content

Conversation

@virkt25
Copy link
Contributor

@virkt25 virkt25 commented Jun 14, 2018

fixes #886

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@virkt25 virkt25 self-assigned this Jun 14, 2018
@virkt25 virkt25 requested a review from a team June 14, 2018 00:43
@virkt25
Copy link
Contributor Author

virkt25 commented Jun 14, 2018

Wanted to get an opinion on this ... with this change we will see the following messages:

  • datasource: db was created in /src/datasources/db.datasource.ts
  • controller: FooController was created in /src/controllers/foo.controller.ts

I was wondering if it would be better to have the following messages? -- more readily extendable to other artifacts imo.

  • datasource: DataSource db was created in /src/datasources/db.datasource.ts
  • controller: Controller foo was created in /src/controllers/foo.controller.ts

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion about these messages, both proposed forms are fine with me.

@dhmlau
Copy link
Member

dhmlau commented Jun 14, 2018

If I have to choose, I'd prefer the 2nd one (with the artifact type name), but either way is good.

@virkt25
Copy link
Contributor Author

virkt25 commented Jun 14, 2018

Updated to Option 2

@virkt25 virkt25 merged commit d602ded into master Jun 14, 2018
@virkt25 virkt25 deleted the cli-create-msg branch June 14, 2018 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CLI] Remove the automatic "Controller" suffix from the controller command

5 participants