docs: describe how to tests services #1445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
shimks
approved these changes
Jun 21, 2018
| #### Obtain a Service Proxy instance | ||
|
|
||
| In | ||
| [./Calling-other-APIs-and-Web-Services.md#make-service-proxies-easier-to-test], |
Member
Author
There was a problem hiding this comment.
Oops, I forgot to commit and push fixes I made after I run Jekyll to render the updates. PTAL at 786ae96
shimks
approved these changes
Jun 21, 2018
jannyHou
approved these changes
Jun 21, 2018
| protected datasource: juggler.DataSource = new GeocoderDataSource(), | ||
| ) {} | ||
|
|
||
| value(): GeocoderService { |
Contributor
There was a problem hiding this comment.
nitpick: is getService a function provided by us or user defines it in the provider?
Member
Author
There was a problem hiding this comment.
Good catch! getService is coming from @loopback/service-proxy package, see http://apidocs.loopback.io/@loopback%2fdocs/service-proxy.html#9.
I'll add an explicit import to the code snippet.
bajtos
force-pushed
the
docs/testing-services
branch
from
786ae96 to
c33b8df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UpdateTesting-your-application and Calling-other-APIs-and-web-services to describe how to test service proxies.
This task is a part of #1311, see also #1441 which is updating Todo tutorial with similar changes.
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated