Skip to content

fix(cli): remove dist-util from project templates #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raymondfeng merged 1 commit into from
Oct 6, 2018
Merged

fix(cli): remove dist-util from project templates #1809

raymondfeng merged 1 commit into from
Oct 6, 2018

Conversation

@bajtos
Copy link
Member

@bajtos bajtos commented Oct 5, 2018 •
edited
Loading

This is a follow-up for #1803 fixing few places using dist-util that I did not notice.

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@bajtos bajtos self-assigned this Oct 5, 2018
@bajtos bajtos requested a review from raymondfeng October 5, 2018 11:54
@bajtos bajtos force-pushed the fix/index-templates branch from b5bda3c to dae79f0 Compare October 5, 2018 12:01
@bajtos bajtos changed the title fix(cli): remove dist-util from index templates fix(cli): remove dist-util from project templates Oct 5, 2018
@bajtos bajtos mentioned this pull request Oct 5, 2018
Merged
3 tasks
@bajtos bajtos force-pushed the fix/index-templates branch from dae79f0 to 37a254d Compare October 5, 2018 12:22
@raymondfeng raymondfeng merged commit f6c3048 into master Oct 6, 2018
@raymondfeng raymondfeng deleted the fix/index-templates branch October 6, 2018 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondfeng raymondfeng raymondfeng approved these changes

+1 more reviewer

@b-admike b-admike b-admike approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bajtos bajtos

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bajtos @raymondfeng @b-admike