Skip to content

docs(cli): use a custom repository base class #2317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bajtos merged 3 commits into from Feb 4, 2019
Merged

docs(cli): use a custom repository base class #2317

bajtos merged 3 commits into from Feb 4, 2019

Conversation

@ghost
Copy link

@ghost ghost commented Jan 31, 2019

fix #2149

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@ghost ghost requested review from bajtos and raymondfeng as code owners January 31, 2019 12:11
@ghost
Copy link
Author

ghost commented Jan 31, 2019

@bajtos @raymondfeng This is the documentation for #2235

@nabdelgadir
Copy link
Contributor

nabdelgadir commented Jan 31, 2019

@gczobel-f5 thanks for the contribution! Can you run npm run lint:fix to fix the formatting?

@dhmlau dhmlau assigned ghost Jan 31, 2019
@ghost ghost closed this Feb 3, 2019
@ghost ghost deleted the patch-1 branch February 3, 2019 09:59
@ghost ghost restored the patch-1 branch February 3, 2019 10:02
@ghost ghost reopened this Feb 3, 2019
@ghost
Copy link
Author

ghost commented Feb 3, 2019

@gczobel-f5 thanks for the contribution! Can you run npm run lint:fix to fix the formatting?
@nabdelgadir Done

bajtos
bajtos approved these changes Feb 4, 2019
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bajtos bajtos merged commit 0e92b88 into loopbackio:master Feb 4, 2019
@bajtos
Copy link
Member

bajtos commented Feb 4, 2019

Landed, thank you @gczobel-f5 for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondfeng raymondfeng Awaiting requested review from raymondfeng

Assignees

No one assigned

Labels

CLI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CLI] Use a custom Repository base class

3 participants

@nabdelgadir @bajtos @dhmlau