fix(rest-explorer): allow explorer for a rest app to be mounted to express #2489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…press This is a follow-up to #2387
bajtos
reviewed
Feb 28, 2019
| this.response.redirect(301, this.request.url + '/'); | ||
| let url = this.request.url + '/'; | ||
| if (this.request.baseUrl && this.request.baseUrl !== '/') { | ||
| url = this.request.baseUrl + url; |
Member
There was a problem hiding this comment.
FWIW, this can be simplified using req.originalUrl, see #2508
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #2387. It makes sure REST explorer also honors the
baseUrl.Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated