Skip to content

fix(example-express-composition): use rest options #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nabdelgadir merged 1 commit into from
Mar 7, 2019
Merged

fix(example-express-composition): use rest options #2542

nabdelgadir merged 1 commit into from
Mar 7, 2019

Conversation

@nabdelgadir
Copy link
Contributor

@nabdelgadir nabdelgadir commented Mar 6, 2019

See #2306 (comment).

Updating the express-composition example to use the host and port from ApplicationConfig.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@nabdelgadir nabdelgadir self-assigned this Mar 6, 2019
b-admike
b-admike approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@b-admike b-admike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@nabdelgadir nabdelgadir merged commit 7e22757 into master Mar 7, 2019
@nabdelgadir nabdelgadir deleted the add-rest-properties-to-example branch March 7, 2019 13:54
bajtos
bajtos reviewed Mar 7, 2019
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondfeng raymondfeng raymondfeng approved these changes

+3 more reviewers

@bajtos bajtos bajtos left review comments

@jannyHou jannyHou jannyHou approved these changes

@b-admike b-admike b-admike approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nabdelgadir nabdelgadir

Labels

Examples

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nabdelgadir @raymondfeng @bajtos @jannyHou @b-admike