Skip to content

Conversation

@raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented Mar 28, 2019

Extracted from #2635:

Make sure binding cache is cleared if the binding is bound to a new value provider or scope

  • The binding instance may cache values for contexts based on the scope
  • If an existing binding changes its value provider or scope, the cache should be invalidated.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@raymondfeng raymondfeng requested a review from bajtos as a code owner March 28, 2019 14:59
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this smaller pull request ❤️

I ran of time today, I'll review the changes in more detail tomorrow.

@raymondfeng raymondfeng requested a review from bajtos March 28, 2019 16:39
@raymondfeng raymondfeng added the IoC/Context @loopback/context: Dependency Injection, Inversion of Control label Mar 28, 2019
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@raymondfeng raymondfeng merged commit 122fe7b into master Apr 1, 2019
@raymondfeng raymondfeng deleted the fix-binding-cache branch April 1, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature IoC/Context @loopback/context: Dependency Injection, Inversion of Control

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants