Skip to content

docs: update circular dependency of repositories tests #2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
agnes512 merged 1 commit into from
May 23, 2019
Merged

docs: update circular dependency of repositories tests #2948

agnes512 merged 1 commit into from
May 23, 2019

Conversation

@agnes512
Copy link
Contributor

@agnes512 agnes512 commented May 23, 2019

fixed the code sample of givenEmptyDatabase for two repositories that have circular dependency

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

jannyHou
jannyHou approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM.

@agnes512 agnes512 merged commit 1fece5f into master May 23, 2019
@agnes512 agnes512 deleted the docCircularDependency branch May 23, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nabdelgadir nabdelgadir nabdelgadir approved these changes

@bajtos bajtos Awaiting requested review from bajtos

@raymondfeng raymondfeng Awaiting requested review from raymondfeng

+1 more reviewer

@jannyHou jannyHou jannyHou approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

unclear documentation about test setup with circular dependency of repositories

4 participants

@agnes512 @jannyHou @nabdelgadir