Refactor openapi guards to use the upstream version #2974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xed by now Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
bajtos
commented
May 27, 2019
| * See https://github.com/Microsoft/TypeScript/issues/26985 | ||
| */ | ||
| // import {OpenApiSpec} from '@loopback/openapi-v3-types'; | ||
| import {OpenAPIObject as OpenApiSpec} from 'openapi3-ts'; |
Member
Author
There was a problem hiding this comment.
microsoft/TypeScript#26985 has been fixed, the workaround is no longer needed.
3 tasks
nabdelgadir
approved these changes
May 27, 2019
nabdelgadir
reviewed
May 27, 2019
Contributor
nabdelgadir
left a comment
nabdelgadir
left a comment
There was a problem hiding this comment.
CI is failing because of the code linter, PTAL 👍
Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
bajtos
force-pushed
the
refactor/openapi-guards
branch
from
2cb4b50 to
070dbe4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In metadevpro/openapi3-ts#46, I contributed our type guards to
openapi3-tspackage. This pull request is updating loopback-next to leverage that.See also #301
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈