fix: mention required loopback-boot version for mounting a lb3 app #3122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabdelgadir
force-pushed
the
loopback-boot-doc
branch
from
456ece9 to
2542b38
Compare
Contributor
Author
|
It works with |
b-admike
approved these changes
Jun 12, 2019
nabdelgadir
changed the title
nabdelgadir
force-pushed
the
loopback-boot-doc
branch
from
2542b38 to
c5cb341
Compare
dhmlau
approved these changes
Jun 13, 2019
bajtos
approved these changes
Jun 13, 2019
| debug('Loading LB3 app from', this.appPath); | ||
| const lb3App = require(this.appPath); | ||
|
|
||
| debug('Make sure loopback-boot@3.2.1 or higher is installed'); |
Member
There was a problem hiding this comment.
As a user seeing this message, I think I would be confused. If I am already using supported loopback-boot version, then why am I being told to use it?
Are you trying to offer advice for users that may observe that application never finishes to boot because they are using an old versions of loopback-boot? If that's the case, then I am proposing a slightly different message.
Suggested change
| debug('Make sure loopback-boot@3.2.1 or higher is installed'); | |
| debug('If your LB3 app does not boot correctly then make sure it is using loopback-boot version 3.2.1 or higher.'); |
Thoughts?
Contributor
Author
There was a problem hiding this comment.
Yes, I agree this is better. I'll make the change. 👍
jannyHou
approved these changes
Jun 13, 2019
nabdelgadir
force-pushed
the
loopback-boot-doc
branch
from
c5cb341 to
a96aac5
Compare
nabdelgadir
force-pushed
the
loopback-boot-doc
branch
from
a96aac5 to
23643d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3104.
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈