Skip to content

feat(cli): enable source map for npm start script #3228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raymondfeng merged 1 commit into from
Jun 24, 2019
Merged

feat(cli): enable source map for npm start script #3228

raymondfeng merged 1 commit into from
Jun 24, 2019

Conversation

@raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented Jun 24, 2019 •
edited
Loading

Implements #3223

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@raymondfeng raymondfeng requested a review from bajtos as a code owner June 24, 2019 16:47
b-admike
b-admike approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@b-admike b-admike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@raymondfeng raymondfeng merged commit 1882240 into master Jun 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the cli-source-map branch June 24, 2019 20:13
@jannyHou
Copy link
Contributor

jannyHou commented Jun 24, 2019

cool LGTM 👍

@dhmlau dhmlau mentioned this pull request Jun 25, 2019
Closed
@emonddr
Copy link
Contributor

emonddr commented Jun 25, 2019

Nice feature

@simonbrunel simonbrunel mentioned this pull request Apr 20, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bajtos bajtos Awaiting requested review from bajtos

1 more reviewer

@b-admike b-admike b-admike approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@raymondfeng @jannyHou @emonddr @b-admike