Skip to content

Conversation

@nabdelgadir
Copy link
Contributor

See #3309 (review).

  • Explain in API docs that the "partial" option is overridden by the "optional" option.
  • Test that partial is still overridden when it is set to false

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@nabdelgadir nabdelgadir self-assigned this Jul 16, 2019
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@nabdelgadir nabdelgadir merged commit d2b22f4 into master Jul 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the partial-optional-doc branch July 16, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants