feat: allow custom decorator name for error messages #3625
Conversation
raymondfeng
force-pushed
the
improve-metadata-debugging
branch
from
801cbc1 to
9f61b6e
Compare
raymondfeng
changed the title
| return AuthorizeMethodDecoratorFactory.createDecorator( | ||
| AUTHORIZATION_METHOD_KEY, | ||
| spec, | ||
| {decoratorName: '@authorize'}, |
There was a problem hiding this comment.
@raymondfeng why do we need provide the decorator name in the options? it could be inferred from the AUTHORIZATION_METHOD_KEY right?
There was a problem hiding this comment.
No, the decorator name @authorize cannot be inferred from AUTHORIZATION_METHOD_KEY, which can be a free-form string.
| } | ||
|
|
||
| function testDecorator(spec: object): ClassDecorator { | ||
| return ClassDecoratorFactory.createDecorator('test', spec, { |
There was a problem hiding this comment.
same question here, test and @test seems duplicate, and what would happen if they are different?
There was a problem hiding this comment.
The first argument is the key for the metadata, it can be test or test.key, or other unique strings. The second one is for the decorator function name.
| class MyController {} | ||
| }).to.throw( | ||
| /Decorator cannot be applied more than once on class MyController/, | ||
| /ClassDecorator cannot be applied more than once on class MyController/, |
There was a problem hiding this comment.
+1 to provide a meaningful default name when no decoratorName metadata was supplied.
bajtos
added
developer-experience
Extracted and improved from #3617
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈