fix(context): allow inject to be explicitly invoked for class ctor args
#3634
Conversation
bajtos
added
the
IoC/Context
bajtos
force-pushed
the
fix/context-markParameterOrPropertyAsInjected
branch
from
a19af75 to
d7c4001
Compare
| return function markParameterOrPropertyAsInjected( | ||
| target: Object, | ||
| member: string, | ||
| member: string | undefined, |
There was a problem hiding this comment.
The ParameterDecorator type from TypeScript is declared as follows:
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;Can we use '' for constructor parameters?
There was a problem hiding this comment.
Interestingly, at runtime, the propertyKey is undefined in constructor cases.
There was a problem hiding this comment.
Interestingly, at runtime, the
propertyKeyisundefinedin constructor cases.
That's the weird thing!
raymondfeng
left a comment
raymondfeng
left a comment
There was a problem hiding this comment.
I'm fine to merge this PR as the undefined is given for member at runtime for the constructor even though it's different from the type definition. Maybe we should report the consistency to TypeScript.
…args Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
raymondfeng
force-pushed
the
fix/context-markParameterOrPropertyAsInjected
branch
from
d7c4001 to
e1ecd2c
Compare
I was considering that, but was lazy to fill the report 🙈 Here we go: microsoft/TypeScript#33260 |
See the discussion in #3617
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈