Skip to content

fix(repository-tests): unify the usage of MixedIdType for all tests #3647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agnes512 merged 1 commit into from
Sep 3, 2019
Merged

fix(repository-tests): unify the usage of MixedIdType for all tests #3647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/repository-tests/src/crud/create-retrieve.suite.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import {
property,
} from '@loopback/repository';
import {expect, toJSON} from '@loopback/testlab';
import {MixedIdType} from '../helpers.repository-tests';
import {
deleteAllModelsInDefaultDataSource,
withCrudCtx,
Expand All @@ -38,7 +39,7 @@ export function createRetrieveSuite(
generated: true,
description: 'The unique identifier for a product',
})
id: number | string;
id: MixedIdType;

@property({type: 'string', required: true})
name: string;
Expand Down
3 changes: 2 additions & 1 deletion packages/repository-tests/src/crud/freeform-properties.suite.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {Entity, model, property} from '@loopback/repository';
import {EntityCrudRepository} from '@loopback/repository';
import {expect, skipIf, toJSON} from '@loopback/testlab';
import {Suite} from 'mocha';
import {MixedIdType} from '../helpers.repository-tests';
import {
withCrudCtx,
deleteAllModelsInDefaultDataSource,
Expand Down Expand Up @@ -37,7 +38,7 @@ export function freeformPropertiesSuite(
id: true,
description: 'The unique identifier for a product',
})
id: number | string;
id: MixedIdType;

@property({type: 'string', required: true})
name: string;
Expand Down
3 changes: 2 additions & 1 deletion packages/repository-tests/src/crud/replace-by-id.suite.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import {Entity, model, property} from '@loopback/repository';
import {AnyObject, EntityCrudRepository} from '@loopback/repository';
import {expect, toJSON} from '@loopback/testlab';
import {MixedIdType} from '../helpers.repository-tests';
import {
deleteAllModelsInDefaultDataSource,
withCrudCtx,
Expand All @@ -31,7 +32,7 @@ export function createSuiteForReplaceById(
generated: true,
description: 'The unique identifier for a product',
})
id: number | string;
id: MixedIdType;

@property({type: 'string', required: true})
name: string;
Expand Down
4 changes: 2 additions & 2 deletions packages/repository-tests/src/crud/transactions.suite.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {
} from '@loopback/repository';
import {expect, skipIf, toJSON} from '@loopback/testlab';
import {Suite} from 'mocha';
import {withCrudCtx} from '../helpers.repository-tests';
import {withCrudCtx, MixedIdType} from '../helpers.repository-tests';
import {
CrudFeatures,
CrudTestContext,
Expand Down Expand Up @@ -42,7 +42,7 @@ export function transactionSuite(
generated: true,
description: 'The unique identifier for a product',
})
id: number | string;
id: MixedIdType;

@property({type: 'string', required: true})
name: string;
Expand Down