Skip to content

Improve snapshot matcher #3776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bajtos merged 2 commits into from
Sep 26, 2019
Merged

Improve snapshot matcher #3776

bajtos merged 2 commits into from
Sep 26, 2019

Conversation

@bajtos
Copy link
Member

@bajtos bajtos commented Sep 20, 2019 •
edited
Loading

Two commits:

  1. print help on updating snapshots when some snapshots were not matched
  2. write snapshot files in parallel

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@bajtos bajtos requested a review from raymondfeng as a code owner September 20, 2019 08:03
@bajtos bajtos self-assigned this Sep 20, 2019
@bajtos bajtos mentioned this pull request Sep 20, 2019
Merged
4 tasks
raymondfeng
raymondfeng reviewed Sep 20, 2019
View reviewed changes
raymondfeng
raymondfeng reviewed Sep 20, 2019
View reviewed changes
@bajtos bajtos force-pushed the feat/improve-snapshots branch from eb4821d to 1dd77d4 Compare September 23, 2019 07:01
@bajtos
Copy link
Member Author

bajtos commented Sep 23, 2019

@raymondfeng updated per your suggestion, LGTY now?

@bajtos bajtos force-pushed the feat/improve-snapshots branch from 1dd77d4 to 7314e92 Compare September 23, 2019 07:03
raymondfeng
raymondfeng reviewed Sep 23, 2019
View reviewed changes
raymondfeng
raymondfeng reviewed Sep 23, 2019
View reviewed changes
agnes512
agnes512 approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@agnes512 agnes512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once Raymond's comments are addressed

@bajtos
feat(cli): print help on updating snapshots when some snapshots were …
e14934b 
…not matched

Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
@bajtos
feat(cli): write snapshot files in parallel
f3e754b 
Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
@bajtos bajtos force-pushed the feat/improve-snapshots branch from 7314e92 to f3e754b Compare September 26, 2019 06:13
@bajtos bajtos merged commit a16ae34 into master Sep 26, 2019
@bajtos bajtos deleted the feat/improve-snapshots branch September 26, 2019 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondfeng raymondfeng raymondfeng left review comments

@nabdelgadir nabdelgadir nabdelgadir approved these changes

@hacksparrow hacksparrow Awaiting requested review from hacksparrow

+1 more reviewer

@agnes512 agnes512 agnes512 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bajtos bajtos

Labels

CLI feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bajtos @raymondfeng @nabdelgadir @agnes512