docs: update generators #3791
Merged
docs: update generators #3791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhmlau
approved these changes
Sep 23, 2019
Contributor
|
Do we have any documentation for |
jannyHou
force-pushed
the
docs/update-generators
branch
from
961d7ce to
b6bc637
Compare
Contributor
Author
|
@agnes512 Added more doc for the model cli generator. PTAL thanks. |
agnes512
approved these changes
Sep 23, 2019
Contributor
agnes512
left a comment
agnes512
left a comment
There was a problem hiding this comment.
I think my question was about the required id in model and the omit id setting in the controller.
And I just saw the PR For controller generator, infer id omitted from the existing model class file #3757. If users don't have to answer an extra prompt about omitting id when they set id as required, this PR looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Todo tutorial according to changes in model generator and controller generator
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈