feat(test-repository-postgresql): run repository tests for postgresql

[nabdelgadir]

Resolves #3436.

Added acceptance/repository-postgresql package in order for repository-tests to be run for PostgreSQL.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

• npm test passes on your machine
• New tests added or existing tests modified to cover all changes
• Code conforms with the style guide
• API Documentation in code was updated
• Documentation in /docs/site was updated
• Affected artifact templates in packages/cli were updated
• Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

[bajtos]

Looks pretty good, assuming that tests are passing :)

[nabdelgadir]

Re the coverage drop: the transactions test suite isn't run by the memory database, but it's run by acceptance/mysql and acceptance/postgresql.

[bajtos]

Here are steps I did to verify these changes:

git checkout postgresql-tests
npm i
npm run build
cd acceptance/repository-postgresql
source setup.sh
npm t

One of the tests failed:

  1) PostgreSQL + DefaultTransactionalRepository
       CRUD Repository operations
         transactions
           create-retrieve with transactions
             should not use transaction with another repository:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/bajtos/src/loopback/next/acceptance/repository-postgresql/dist/__tests__/postgresql-default-repository.acceptance.js)
      at listOnTimeout (internal/timers.js:531:17)
      at processTimers (internal/timers.js:475:7)

Could you PTAL?

[bajtos]

BTW I find it weird that the test is failing with a timeout, I would expect it to throw an error saying that the configured database does not exist. This is probably a bug in our PostgreSQL connector, therefore out of scope of this pull request, but possibly worth fixing or at least opening a GH issue for.

[emonddr]

BTW I find it weird that the test is failing with a timeout, I would expect it to throw an error saying that the configured database does not exist. This is probably a bug in our PostgreSQL connector, therefore out of scope of this pull request, but possibly worth fixing or at least opening a GH issue for.

@nabdelgadir ^ please respond to this comment

[emonddr]

@nabdelgadir

Regarding

Re the coverage drop: the transactions test suite isn't run by the memory database, but it's run by acceptance/mysql and acceptance/postgresql.

Do you have a proposed fix (new set of tests) to bring the coverage back up to an appropriate level?

Right now, the CI is complaining

[nabdelgadir]

BTW I find it weird that the test is failing with a timeout, I would expect it to throw an error saying that the configured database does not exist. This is probably a bug in our PostgreSQL connector, therefore out of scope of this pull request, but possibly worth fixing or at least opening a GH issue for.

@bajtos I tried creating an app to reproduce this error, and it actually does throw a descriptive error (e.g. error: database "testdb" does not exist) and it throws it if I run that test individually. So the connector is throwing the error properly. It might be hard to resolve this issue if it needs this specific setup in order to be tested.

[nabdelgadir]

Regarding

Re the coverage drop: the transactions test suite isn't run by the memory database, but it's run by acceptance/mysql and acceptance/postgresql.

Do you have a proposed fix (new set of tests) to bring the coverage back up to an appropriate level?

Right now, the CI is complaining

@emonddr Not really sure how to bring it back up because as I said the coverage only accounts for tests run by the memory database and the memory database doesn't support transactions. So the coverage for the file it's complaining about can't be brought back up. But do you have something in mind?

[nabdelgadir]

Replacing because --include-filtered-dependencies has been renamed.

[emonddr]

@slnode test please

[emonddr]

@nabdelgadir , did you run the tests locally and all tests passed? Referring to @bajtos comment in #3853 (review) .

[nabdelgadir]

@nabdelgadir , did you run the tests locally and all tests passed? Referring to @bajtos comment in #3853 (review) .

Yes, they work locally.