-
Notifications
You must be signed in to change notification settings - Fork 1.1k
docs: update "Understanding differences between LB3 and LB4" #3915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
88b5e2e to
a6a9503
Compare
| </td> | ||
| <td> | ||
| OpenAPI code generators, <br>e.g. | ||
| <a href="https://swagger.io/tools/swagger-codegen/"><code>swagger-codegen</code></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please list more examples for OpenAPI code generators? Personally I'm still searching for an sdk generator for Angular 7 which replaces lb3 sdk created by loopback-sdk-builder. swagger-codegen@3 currently does not support angular. Migrating the fronend sdk is one of the blockers of our lb4 migration story. This could be helpful for other developers too.
stackoverflow question: which openapi client sdk for loopback4 and angular?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derdeka thank you for the suggestion, I'll add openapi-generator and ng-openapi-gen to the list.
When you find a generator that works well for you, it would be great if you could contribute documentation (or even a short migration guide) to help other LoopBack + Angular users.
agnes512
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM
| <tr> | ||
| <td>DataSource</td> | ||
| <td>JSON</td> | ||
| <td>TypeScript and JSON;</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<td>TypeScript and JSON;</td> -> <td>TypeScript and JSON;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍
dhmlau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as the first iteration. I have some comments about the JavaScript support and loopback-component-storage.
No changes in the actual content were made. Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
Makes sense. I would also make it more clear that we don't have any plans to rework LB3 components like Let's do these improvements in a new pull request, this one is already too large.
IDK, to be honest 🤷♂ I think we need to do a short spike to find the answer. I am not sure if this is more important than our existing 2019Q4 backlog though. |
Update the content to reflect features delivered since the page was created. Add more entries for LB3 features and components. Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
a6a9503 to
72b15f7
Compare
The first commit switches the text from a giant Markdown table to raw HTML table that's easier to edit and review. No text changes were made here.
The second commit improves the content to reflect features delivered since the page was
created and adds more entries for LB3 features and components.
This PR is a part of #3718
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈