Skip to content

Conversation

@bajtos
Copy link
Member

@bajtos bajtos commented Oct 11, 2019

The first commit switches the text from a giant Markdown table to raw HTML table that's easier to edit and review. No text changes were made here.

The second commit improves the content to reflect features delivered since the page was
created and adds more entries for LB3 features and components.

This PR is a part of #3718

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@bajtos bajtos added the Docs label Oct 11, 2019
@bajtos bajtos requested review from a team October 11, 2019 14:46
@bajtos bajtos requested a review from raymondfeng as a code owner October 11, 2019 14:46
@bajtos bajtos self-assigned this Oct 11, 2019
@bajtos bajtos force-pushed the docs/lb3-lb4-diffs branch 2 times, most recently from 88b5e2e to a6a9503 Compare October 11, 2019 14:52
@bajtos bajtos requested a review from dhmlau October 11, 2019 14:55
</td>
<td>
OpenAPI code generators, <br>e.g.
<a href="https://swagger.io/tools/swagger-codegen/"><code>swagger-codegen</code></a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please list more examples for OpenAPI code generators? Personally I'm still searching for an sdk generator for Angular 7 which replaces lb3 sdk created by loopback-sdk-builder. swagger-codegen@3 currently does not support angular. Migrating the fronend sdk is one of the blockers of our lb4 migration story. This could be helpful for other developers too.

stackoverflow question: which openapi client sdk for loopback4 and angular?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derdeka thank you for the suggestion, I'll add openapi-generator and ng-openapi-gen to the list.

When you find a generator that works well for you, it would be great if you could contribute documentation (or even a short migration guide) to help other LoopBack + Angular users.

Copy link
Contributor

@agnes512 agnes512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

<tr>
<td>DataSource</td>
<td>JSON</td>
<td>TypeScript and JSON;</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<td>TypeScript and JSON;</td> -> <td>TypeScript and JSON;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as the first iteration. I have some comments about the JavaScript support and loopback-component-storage.

No changes in the actual content were made.

Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
@bajtos
Copy link
Member Author

bajtos commented Oct 14, 2019

I wonder if we should mention we won't be aiming for JavaScript support in a near future.

Makes sense. I would also make it more clear that we don't have any plans to rework LB3 components like loopback-component-push or loopback-component-storage to LB4 style.

Let's do these improvements in a new pull request, this one is already too large.

I saw a comment from @raymondfeng:

I think it's possible to use loopback-component-storage as a connector and use LB4 service-proxy to access such operations in a controller.

So.. we've tried and know that it's not available now?

IDK, to be honest 🤷‍♂ I think we need to do a short spike to find the answer. I am not sure if this is more important than our existing 2019Q4 backlog though.

Update the content to reflect features delivered since the page was
created.

Add more entries for LB3 features and components.

Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
@bajtos bajtos force-pushed the docs/lb3-lb4-diffs branch from a6a9503 to 72b15f7 Compare October 14, 2019 07:15
@bajtos bajtos merged commit 35073c2 into master Oct 14, 2019
@bajtos bajtos deleted the docs/lb3-lb4-diffs branch October 14, 2019 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants