-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(repository): add interface for hasManyThrough #4247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(repository): add interface for hasManyThrough #4247
Conversation
bajtos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @KalleV for picking up the work on HasManyThrough relation! 👏🥳
In #2359 (comment), we discussed slightly different structure of the relation definition, one that is more ergonomic for consumers. Can you please apply the changes suggested in that thread?
|
Hi @bajtos . Is there any other changes you would like to see to the new interface? |
bajtos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
Could you please squash all commits into a single one and provide a descriptive commit message per our guidelines?
If you are not familiar with git history manipulation, then you can find detailed help in our docs.
@strongloop/sq-lb-apex can one of you take care of this pull request please and get it landed?
66f3ab9 to
e38d823
Compare
|
Seeing commit lint failures for the Node 12 environment in Travis: https://travis-ci.com/strongloop/loopback-next/jobs/267005076 but it seems to be unrelated to my commit. |
|
@KalleV, for some reason, there are other commit messages in your commit. I remember someone else had a similar problem that they had to rebase it. Could you please try to |
|
@agnes512, since you're more familiar with model relations, could you please review and help this PR to land? Thanks. |
Add experimental interface for the new relation type "hasManyThrough" to support many-to-many model relations.
e38d823 to
ef9c83b
Compare
agnes512
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution!
|
In case you're interested, there is a LoopBack Developer badge for those who made contributions to LoopBack. Please check this out: https://www.ibm.com/services/learning/ites.wss/zz-en?pageType=badges&id=0de05804-8037-4791-ac83-09829b566d51. Thanks! |
Adds interface for the new relation type "hasManyThrough" to support many-to-many model relations.
This PR is a continuation of #2359 and implements the first change described in #2359 (comment).
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈