Skip to content

Conversation

@dougal83
Copy link
Contributor

@dougal83 dougal83 commented Dec 19, 2019

Adding titles to json filter schemas as groundwork toward openapi spec ref consolidation based on title property. See #4290

!! Unable to run tests on local Win10 machine. Is there a docker image that can be used to run tests?

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@dougal83 dougal83 force-pushed the feat(repository-json-schema)--add-title-to-filter-schemas branch from 3bc349b to f9946d4 Compare December 19, 2019 15:42
@dhmlau dhmlau requested a review from jannyHou December 19, 2019 16:03
@dhmlau
Copy link
Member

dhmlau commented Dec 19, 2019

@jannyHou , could you please review? Thanks.

@dougal83 dougal83 force-pushed the feat(repository-json-schema)--add-title-to-filter-schemas branch from f9946d4 to 947702c Compare December 23, 2019 17:31
add title property to filter schemas(filter, where, scope) in preparation for openapi schema consolidation
@dougal83 dougal83 force-pushed the feat(repository-json-schema)--add-title-to-filter-schemas branch from 947702c to 9679aa8 Compare December 23, 2019 18:06
@dougal83 dougal83 closed this Jan 1, 2020
@dougal83 dougal83 deleted the feat(repository-json-schema)--add-title-to-filter-schemas branch January 1, 2020 20:10
@dougal83 dougal83 restored the feat(repository-json-schema)--add-title-to-filter-schemas branch January 1, 2020 20:14
@dougal83 dougal83 deleted the feat(repository-json-schema)--add-title-to-filter-schemas branch January 1, 2020 20:14
@dougal83
Copy link
Contributor Author

dougal83 commented Jan 1, 2020

Relocated: #4355 resubmitted. dougal83:feat(repository-json-schema)add-title-to-filter-schemas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants