-
Notifications
You must be signed in to change notification settings - Fork 1.1k
docs: update todo-list example #4412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
91bd544 to
15bcaac
Compare
15bcaac to
6f6fe6f
Compare
|
Going through the updated doc right now. Not sure why we 'deselect' Enable docker, and leave all the others checked. Any reason? |
That's a good question. I think you're referring to the todo tutorial: https://loopback.io/doc/en/lb4/todo-tutorial-scaffolding.html#create-your-app-scaffolding, right? Thoughts? @strongloop/loopback-maintainers |
|
Thanks for adding that commit @emonddr!
@dhmlau @emonddr I think the reason was because the option says it adds |
|
Personally, I'd prefer to keep all the defaults in the "features" prompt and make the necessary changes in the example app. |
dac8d26 to
c9d6537
Compare
c9d6537 to
5f55210
Compare
jannyHou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 great effort!
agnes512
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job :D
Just have one concern about hasOne & belongsTo. The rest are just some nitpicks.
docs/site/tutorials/todo-list/todo-list-tutorial-has-one-relation.md
Outdated
Show resolved
Hide resolved
5f55210 to
af62fc3
Compare
agnes512
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
658c889 to
6c3c0e0
Compare
6c3c0e0 to
0e45a08
Compare
Update the
todo-listdocs to match the example's code.Closes #4161 and closes #2050.
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈