Skip to content

docs: update auth options #4580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jannyHou merged 1 commit into from
Feb 7, 2020
Merged

docs: update auth options #4580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/site/Loopback-component-authorization.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ class.
defaultDecision: AuthorizationDecision.DENY,
};

const binding = app.component(AuthorizationComponent);
app.configure(binding.key).to(options);
app.configure(AuthorizationBindings.COMPONENT).to(options);
Copy link
Contributor

@derdeka derdeka Feb 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that configure after component works? On other places we have to do configure before component to make it working?

Copy link
Contributor Author

@jannyHou jannyHou Feb 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derdeka I wasn't sure, so I verified with app in #4571, you can read the PR description to see my testing result.

this.configure() is called in the app constructor, and whenever the authorization interceptor is invoked, the options will be injected. So I believe after app runs, making API calls will inject the configured options.

Copy link
Contributor

@derdeka derdeka Feb 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to suggest to switch the order to have it consistent with other docs.

Copy link
Contributor Author

@jannyHou jannyHou Feb 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derdeka 👌 switched the order to have the configure before mounting component.

app.component(AuthorizationComponent);
```

- The authorization `options` are provided specifically for enforcing the
Expand Down