refactor: move const into bindings #4831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannyHou
requested review from
agnes512,
bajtos,
deepakrkris,
emonddr,
hacksparrow,
nabdelgadir and
raymondfeng
as code owners
jannyHou
changed the title
emonddr
approved these changes
Mar 10, 2020
raymondfeng
changed the title
jannyHou
force-pushed
the
refactor/oas/enhancer
branch
from
1117cbc to
44dff6c
Compare
raymondfeng
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor const into bindings
will wait for #4693 and rebase
Export
OAS_ENHANCER_SERVICEandOAS_ENHANCER_EXTENSION_POINT_NAMEfrom namespaceOASEnhancerBindingsChecklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈