Skip to content

feat(docs): describe LB3 features not planned in LB4 #4840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raymondfeng merged 1 commit into from
Mar 17, 2020
Merged

feat(docs): describe LB3 features not planned in LB4 #4840

raymondfeng merged 1 commit into from
Mar 17, 2020

Conversation

@bajtos
Copy link
Member

@bajtos bajtos commented Mar 10, 2020

Resolves #3956

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@bajtos bajtos added this to the Mar 2020 milestone Mar 10, 2020
@bajtos bajtos requested review from a team and dhmlau March 10, 2020 10:05
@bajtos bajtos self-assigned this Mar 10, 2020
@bajtos bajtos requested a review from raymondfeng March 10, 2020 10:06
raymondfeng
raymondfeng reviewed Mar 10, 2020
View reviewed changes
nabdelgadir
nabdelgadir approved these changes Mar 10, 2020
View reviewed changes
agnes512
agnes512 approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@agnes512 agnes512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The content LGTM.

Just wondering if we want to change the title to LoopBack 3 components not planned in LoopBack 4 as it talks about components?

@bajtos
Copy link
Member Author

bajtos commented Mar 13, 2020

Just wondering if we want to change the title to LoopBack 3 components not planned in LoopBack 4 as it talks about components?

Please note that offline data access & sync is not a standalone component (an npm package), it's a built-in feature of LB3 core.

In the future, we will probably list more non-component features on this page, for example Realtime server-sent events a.k.a PersistedMode.createChangeStream - another built-in feature that's not available in LB4 yet.

@bajtos bajtos force-pushed the docs/migration-components branch from 4cc07ef to d6c79f4 Compare March 13, 2020 15:06
raymondfeng
raymondfeng reviewed Mar 13, 2020
View reviewed changes
raymondfeng
raymondfeng reviewed Mar 13, 2020
View reviewed changes
raymondfeng
raymondfeng requested changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@raymondfeng raymondfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust references to the file-upload-download example.

@bajtos
feat(docs): describe LB3 features not planned in LB4
0ee87ea 
Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
@bajtos bajtos force-pushed the docs/migration-components branch from d6c79f4 to 0ee87ea Compare March 17, 2020 07:50
@bajtos
Copy link
Member Author

bajtos commented Mar 17, 2020

Please adjust references to the file-upload-download example.

Done.

@raymondfeng LGTY now?

@raymondfeng raymondfeng merged commit 955812c into master Mar 17, 2020
@raymondfeng raymondfeng deleted the docs/migration-components branch March 17, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondfeng raymondfeng raymondfeng approved these changes

@derdeka derdeka derdeka approved these changes

@nabdelgadir nabdelgadir nabdelgadir approved these changes

@dhmlau dhmlau Awaiting requested review from dhmlau

@deepakrkris deepakrkris Awaiting requested review from deepakrkris

+3 more reviewers

@hacksparrow hacksparrow hacksparrow approved these changes

@jannyHou jannyHou jannyHou approved these changes

@agnes512 agnes512 agnes512 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bajtos bajtos

Labels

Docs Migration

Projects

None yet

Milestone

Mar 2020

Development

Successfully merging this pull request may close these issues.

Which official LB3 components are not planned in LB4

8 participants

@bajtos @raymondfeng @hacksparrow @jannyHou @derdeka @nabdelgadir @agnes512