Skip to content

feat(apiconnect): initial implemention of ApiConnectComponent #4851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raymondfeng merged 1 commit into from
Mar 12, 2020
Merged

feat(apiconnect): initial implemention of ApiConnectComponent #4851

raymondfeng merged 1 commit into from
Mar 12, 2020

Conversation

@raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented Mar 10, 2020 •
edited
Loading

This PR adds an extension for IBM API Connect to enhance the OpenAPI spec with x-ibm-configuration extension.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

derdeka
derdeka reviewed Mar 10, 2020
View reviewed changes
achrinza
achrinza reviewed Mar 11, 2020
View reviewed changes
dhmlau
dhmlau reviewed Mar 11, 2020
View reviewed changes
dhmlau
dhmlau approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@deepakrkris deepakrkris mentioned this pull request Mar 12, 2020
Closed
5 tasks
@raymondfeng raymondfeng marked this pull request as ready for review March 12, 2020 19:47
@raymondfeng raymondfeng requested a review from bajtos as a code owner March 12, 2020 19:47
@raymondfeng raymondfeng merged commit ba722f8 into master Mar 12, 2020
@raymondfeng raymondfeng deleted the apiconnect branch March 12, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derdeka derdeka derdeka left review comments

@achrinza achrinza achrinza left review comments

@dhmlau dhmlau dhmlau approved these changes

@bajtos bajtos Awaiting requested review from bajtos

+1 more reviewer

@emonddr emonddr emonddr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@raymondfeng @emonddr @derdeka @achrinza @dhmlau