feat(core): improve application signal handler registration #5020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 2, 2020
raymondfeng
force-pushed
the
improve-app-shutdown
branch
from
b62fdd4 to
2250d44
Compare
raymondfeng
requested review from
emonddr,
hacksparrow and
jannyHou
as code owners
raymondfeng
force-pushed
the
improve-app-shutdown
branch
3 times, most recently
from
b9f4b42 to
ee0df1e
Compare
emonddr
approved these changes
Apr 3, 2020
raymondfeng
force-pushed
the
improve-app-shutdown
branch
from
ee0df1e to
ec6a75a
Compare
raymondfeng
force-pushed
the
improve-app-shutdown
branch
2 times, most recently
from
6328a05 to
c7956ef
Compare
bajtos
reviewed
Apr 7, 2020
raymondfeng
force-pushed
the
improve-app-shutdown
branch
from
c7956ef to
3629439
Compare
Contributor
Author
|
@bajtos PTAL. |
raymondfeng
force-pushed
the
improve-app-shutdown
branch
from
3629439 to
4212146
Compare
bajtos
approved these changes
Apr 9, 2020
Member
bajtos
left a comment
bajtos
left a comment
There was a problem hiding this comment.
LGTM with one minor comment to consider. No further reviews are necessary as far as I am concerned.
emonddr
approved these changes
Apr 9, 2020
Contributor
emonddr
left a comment
emonddr
left a comment
There was a problem hiding this comment.
approve, but one question about a particular import statement.
- only register shutdown listeners when the app starts - unregister process listeners upon explicit stop - fix the test case to clean up process listeners - improve debugging with context name prefix
raymondfeng
force-pushed
the
improve-app-shutdown
branch
from
4212146 to
c53833d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key changes:
Replace #5015
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈