fix(context): fix context subscription manager to not emit errors to its context if there is an error listener is in place #5021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondfeng
requested review from
deepakrkris,
emonddr and
jannyHou
as code owners
Contributor
Author
|
FYI: The PR fixed an unhandled error in the test. As a result, the test coverage goes down a bit, which is expected as the test does not crash or warn unhandled promise rejections. |
raymondfeng
added
the
IoC/Context
bajtos
reviewed
Apr 3, 2020
emonddr
approved these changes
Apr 3, 2020
raymondfeng
force-pushed
the
fix-context-observer-test
branch
from
66aa96b to
2833069
Compare
raymondfeng
changed the title
dhmlau
approved these changes
Apr 3, 2020
…gNotificationsDone
raymondfeng
force-pushed
the
fix-context-observer-test
branch
from
2833069 to
b260731
Compare
raymondfeng
changed the title
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unhandled error is reported when context-observer.unit.ts is run by itself. The root cause is that ContextSubscriptionManager always emits errors to the context chain without checking if there is an error listener on itself.
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈