Skip to content

feat: improve interceptors with composition and registration #5317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raymondfeng merged 5 commits into from
May 4, 2020
Merged

feat: improve interceptors with composition and registration #5317

raymondfeng merged 5 commits into from
May 4, 2020

Conversation

@raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented May 3, 2020 •
edited
Loading

The PR makes it easier to compose and register interceptors. This is a spin-off from #5118

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@raymondfeng raymondfeng self-assigned this May 3, 2020
@raymondfeng raymondfeng added IoC/Context @loopback/context: Dependency Injection, Inversion of Control feature labels May 3, 2020
@raymondfeng raymondfeng force-pushed the improve-interceptors branch from 19d201a to 5af5acd Compare May 3, 2020 18:43
@raymondfeng raymondfeng force-pushed the improve-interceptors branch from 5af5acd to 6fdb816 Compare May 3, 2020 18:49
@raymondfeng raymondfeng mentioned this pull request May 3, 2020
Merged
7 tasks
@dhmlau dhmlau added this to the May 2020 milestone May 4, 2020
agnes512
agnes512 reviewed May 4, 2020
View reviewed changes
Copy link
Contributor

@agnes512 agnes512 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. I notice that we added composeInterceptors and FinalHandler. Are they worth being mentioned in the docs?

@raymondfeng raymondfeng force-pushed the improve-interceptors branch from 92504bf to 6d96fd4 Compare May 4, 2020 15:14
@raymondfeng
Copy link
Contributor Author

raymondfeng commented May 4, 2020

@agnes512 Docs added at https://github.com/strongloop/loopback-next/blob/6d96fd498eba93c176b7c86e2971702c14276b98/docs/site/Interceptors.md.

@raymondfeng raymondfeng requested a review from agnes512 May 4, 2020 15:15
@raymondfeng raymondfeng merged commit 5abe25e into master May 4, 2020
@raymondfeng raymondfeng deleted the improve-interceptors branch May 4, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deepakrkris deepakrkris Awaiting requested review from deepakrkris

@jannyHou jannyHou Awaiting requested review from jannyHou

@bajtos bajtos Awaiting requested review from bajtos

@hacksparrow hacksparrow Awaiting requested review from hacksparrow

2 more reviewers

@emonddr emonddr emonddr approved these changes

@agnes512 agnes512 agnes512 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@raymondfeng raymondfeng

Labels

feature IoC/Context @loopback/context: Dependency Injection, Inversion of Control

Projects

None yet

Milestone

May 2020

Development

Successfully merging this pull request may close these issues.

5 participants

@raymondfeng @emonddr @agnes512 @dhmlau