-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix: bootmixin should use super.component() to get binding key #5516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: bootmixin should use super.component() to get binding key #5516
Conversation
f24c414 to
9c039e7
Compare
|
@mschnee Thanks. Please run |
4fd4159 to
8e4d0a9
Compare
|
@raymondfeng lint complete. Looks good, minus the MacOS test failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mschnee good catch, I left a few suggestions. LGTM 👍
I triggered a new build for the macos test.
b9f1440 to
3e49de2
Compare
|
@jannyHou @raymondfeng I've updated the tests and added documentation, as suggested :) |
|
I see that I added some code that has no coverage- I will update this when I'm back at my computer after the holiday weekend :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pull request, @mschnee! ❤️
I quickly skimmed through the changes and they look good at high level. Please try to get approval from other people who commented in this pull request before you proceed to landing.
jannyHou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
|
@raymondfeng good morning! I'm working on this now :) |
3e49de2 to
e5a915c
Compare
e5a915c to
6c57478
Compare
There is a small misbehavior in
boot.mixin.ts, where upon invokingthis.component(ComponentClass),mountComponentBooterswill assume"components.${class.name}"to be the binding key, even if another key was specified.This presents itself in Applications where components marked with
@bind()using a custom name, and attempting to use them:This PR addresses this, by implementing a similar fix to what was done in
repository.mixin.ts.See also #5477
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈