Skip to content

docs: adding postgres connector tutorial for lb4 #5519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
agnes512 merged 1 commit into from
May 23, 2020
Merged

docs: adding postgres connector tutorial for lb4 #5519

agnes512 merged 1 commit into from
May 23, 2020

Conversation

@agnes512
Copy link
Contributor

@agnes512 agnes512 commented May 22, 2020 •
edited
Loading

Closes #4877

image

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@agnes512 agnes512 force-pushed the pg-tutorial branch 2 times, most recently from fd2ab3e to db6b528 Compare May 22, 2020 01:51
@agnes512 agnes512 marked this pull request as ready for review May 22, 2020 02:07
dhmlau
dhmlau approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear instructions. Good work!
I assume this is going to replace https://loopback.io/doc/en/lb4/Connecting-to-PostgreSQL.html and you'll submit a follow up PR for the sidebar?

@dhmlau dhmlau added the Docs label May 22, 2020
@agnes512 agnes512 mentioned this pull request May 22, 2020
Merged
@agnes512
Copy link
Contributor Author

agnes512 commented May 22, 2020

Clear instructions. Good work!
I assume this is going to replace https://loopback.io/doc/en/lb4/Connecting-to-PostgreSQL.html and you'll submit a follow up PR for the sidebar?

I think once we remove the page in loopbackio/loopback.io#988 it should work 😄

raymondfeng
raymondfeng approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@raymondfeng raymondfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@dhmlau
Copy link
Member

dhmlau commented May 22, 2020

I think once we remove the page in loopbackio/loopback.io#988 it should work 😄

i guess we might want to wait for this to be published first before merging the removal changes in loopback.io, otherwise we'll have broken links. :)

@agnes512 agnes512 merged commit 440add0 into master May 23, 2020
@agnes512 agnes512 deleted the pg-tutorial branch May 23, 2020 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondfeng raymondfeng raymondfeng approved these changes

@dhmlau dhmlau dhmlau approved these changes

@jannyHou jannyHou Awaiting requested review from jannyHou

@hacksparrow hacksparrow Awaiting requested review from hacksparrow

Assignees

@agnes512 agnes512

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Docs] Postgresql connector docs should cover LB4 content

4 participants

@agnes512 @dhmlau @raymondfeng